go_to_line: Avoid byte slicing crash in short status labels#40963
go_to_line: Avoid byte slicing crash in short status labels#40963cppcoffee wants to merge 2 commits intozed-industries:mainfrom
Conversation
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Any chance we can have a test for this?
|
Hi @SomeoneToIgnore , |
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
test_first_char_extraction_utf8_safetyhas already tested the fixed core logic
Whatever it tested, it was not panicking, right?
My point is to recreate a panic that we fix in a separate test: otherwise it might come back later, because nothing ensures it's not broken.
Thank you for adding the new test, but this test does not fail on main for me — which means that we're not recreating a panic that we fix yet.
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
|
In Introduce the |
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
|
Sorry, this doesn't actually seem to be a bug, nor is it related to the crash reported. Thanks for your submission! |
Yes I did, did not you see that in the diff provided here: ?
is unchanged there. Can you provide me a diff that I can |
|
You're right, I've analyzed it and it was indeed my mistake. I'm sorry for the trouble. |



Closes #40962
Release Notes: