Sanitize MCP server names containing whitespace#174
Merged
benbrandt merged 1 commit intozed-industries:mainfrom Mar 5, 2026
Merged
Sanitize MCP server names containing whitespace#174benbrandt merged 1 commit intozed-industries:mainfrom
benbrandt merged 1 commit intozed-industries:mainfrom
Conversation
Codex does not allow whitespace in MCP server names. When an MCP server is configured with a name containing spaces or other whitespace characters, the adapter now replaces each whitespace character with an underscore before passing the name to Codex. Fixes zed-industries#55 Co-Authored-By: Claude <noreply@anthropic.com>
benbrandt
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #55
When an MCP server name contains spaces (or other whitespace), Codex fails to initialize it because the server name is used as a key that must not contain whitespace.
This PR sanitizes MCP server names in the adapter layer by replacing each whitespace character with an underscore before the name is passed to Codex. The fix is applied to both HTTP and Stdio server types.
Changes
src/codex_agent.rs: Replace whitespace in MCP server names with underscores for bothMcpServer::HttpandMcpServer::Stdiovariants.🤖 Generated with Claude Code