fix: inherit process.env when spawning agent subprocess#374
Merged
benbrandt merged 3 commits intozed-industries:mainfrom Mar 4, 2026
Merged
Conversation
In 0.20.0, the env option was introduced with an explicit object spread, but without including process.env. This caused the subprocess to receive an empty environment, stripping HOME, PATH and other inherited variables when spawned from an external editor such as Zed. Add ...process.env as the base so user-provided and gateway env vars still override it, while preserving the parent process environment. Add tests to verify HOME/PATH are inherited and that user-provided vars are merged on top correctly.
|
We require contributors to sign our Contributor License Agreement, and we don't have @joseotaviorf on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
benbrandt
approved these changes
Mar 4, 2026
Member
benbrandt
left a comment
There was a problem hiding this comment.
Thanks! I missed this in my testing yesterday
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0.20.0, the env option was introduced with an explicit object spread, but without including process.env. This caused the subprocess to receive an empty environment, stripping HOME, PATH and other inherited variables when spawned from an external editor such as Zed.
Add ...process.env as the base so user-provided and gateway env vars still override it, while preserving the parent process environment.
Add tests to verify HOME/PATH are inherited and that user-provided vars are merged on top correctly.
Fixes #373
Closes zed-industries/zed#50664