feat: call make uninstall when removing a plugin/snippet#468
feat: call make uninstall when removing a plugin/snippet#468psprint wants to merge 1 commit intozdharma-continuum:mainfrom
Conversation
DRAFT RESPONSEThis is a good idea. However, I still favor using plugin source directory instead of $ZPFX as a prefix for the following reasons. |
|
What are the reasons?
czw., 2 lut 2023, 03:54 użytkownik vladislav doster <
***@***.***> napisał:
… DRAFT RESPONSE
This is a good idea. However, I still favor using plugin source directory
instead of $ZPFX as a prefix for the following reasons.
-
—
Reply to this email directly, view it on GitHub
<#468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOE4CD565JB6YP3UP5G6X3WVMOW3ANCNFSM6AAAAAAUKGFKCQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ping? |
|
As I have said before, I will not review PRs with failing CI checks except when the CI tests are broken or you can't get a check to pass. So, is there an issue generating the documentation? |
|
Yes I cannot generate docs because there is no docker for PCLinuxOS. I've tried RPM for Fedora but it wasn't compatible. |
|
The run hooks function requires a parameter on $5 - the path to the plugin.
It also needs a Makefile with uninstall target.
sob., 29 kwi 2023, 06:21 użytkownik vladislav doster <
***@***.***> napisał:
… This doesn't work for example you gave in #458
<#458>
zi id-as as"null" from"gitlab.matrix.org" configure make'install' for matrix-org/olm
I tried your commit before I changed it. Seems to be since it uses cmake?
[image: Screenshot 2023-04-28 at 23 18 46]
<https://user-images.githubusercontent.com/10052309/235283128-0a8e60e7-d71a-4a59-9c74-7be33961a1a5.png>
—
Reply to this email directly, view it on GitHub
<#468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOE4CACMNCFOZTHUJVXMXDXDSJLXANCNFSM6AAAAAAUKGFKCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@vladdoster It turns out that CMake doesn't support |
|
@vladdoster: I've resolved conflicts (fresh branch) and added CMake support. The commit is all lowercase and has the prefix, I cannot generate zshelldocs because there's no docker for my OS. |
FWIW, You don't need Docker to generate the documentation. I don't use Docker, either, because it is painfully slow (on macOS atleast) due to virtualization.
I use the following: zi for id-as lbin'!build/zsd*' light-mode make'--always-make' null @zdharma-continuum/zshelldoc
|
|
Closing due to the changes were merged in #616 (code found here). |
Description
If the
uninstalltarget is there in theMakefileof the removed plugin/snippet, it'll be run as:make -C {plugin/snippet dir} uninstallbefore removing the dir (withzinit delete).Motivation and Context
@vladdoster mentioned (#333) that
--prefix=$ZPFXinstalled plugins aren't cleaned up lik--prefix=$PWDones, so I addedmake uninstallsupport.Related Issue(s)
#333
Usage examples
# Will first uninstall ctags from the --prefix=($ZPFX,$PWD,etc.) path zinit delete -y unversal-ctags/ctagsHow Has This Been Tested?
Types of changes
Checklist: