fix: produce terms for missing values#592
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b78976b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
martinmaillard
approved these changes
Mar 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 80.61% 80.67% +0.05%
==========================================
Files 138 140 +2
Lines 8172 8252 +80
Branches 518 539 +21
==========================================
+ Hits 6588 6657 +69
- Misses 1581 1592 +11
Partials 3 3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please excuse 68k changed rows in the sample csv. Had to add a column to prepare a test scenario
fixes #481:
csvw:defaultonly accepts string per speccube:UndefinedIRI for column mapped to shared dimension""^^cube:Undefinedfor all other columnssh:datatypeandsh:inare updated accordingly, usingsh:orwhere necessaryAt this time appears impossible to do anything with reference columns, because CSVW does not have any special behaviour when constructing templates from missing values. They will simply be inserted as empty strings into the resulting URI