remove implicit groups#292
Conversation
|
@d-v-b, is this PR ready for review? |
|
@MSanKeys963 yes! |
|
how can we move forward with this? I think it's important to make these changes quickly, before we get skew between implementations. |
|
@zarr-developers/steering-council - this PR has sat without review for 4 months. Can we move it forward please? |
|
@d-v-b: do you want to take a look at the conflict? |
…into no_implicit_groups
done! |
joshmoore
left a comment
There was a problem hiding this comment.
Thanks, @d-v-b.
Merging as an agreed upon "adjustment" of v3 needed to a "spec bug" introduced by removing the concept of a root directory without re-evaluating the explicit/implicit concept.
This is a change that all implementors need to be aware of. See the list of "Changes after Provisional Acceptance" for other such items.
cc: @zarr-developers/implementation-council
|
@joshmoore Please add the following line directly after "Group metadata": |
|
@bjoernthiel is this section not sufficient for your purposes? zarr-specs/docs/v3/core/index.rst Lines 382 to 388 in b880fb3 |
|
aha, for symmetry we should have something like the following statement: zarr-specs/docs/v3/core/index.rst Lines 464 to 465 in b880fb3 in the group section. |
this PR removes support for implicit groups (Zarr groups with no metadata documentation) from the spec. See #291 for the motivation. Besides changing the content of the text, I don't know what else to change, so I'm keeping this a draft for now.
A mergeable version of this PR would include a section explaining what implicit groups are, why they were added previously, and why they are now removed. I am happy to add this if it looks like this PR has legs.
Related discussion: #184