Open zip store from path with zip suffix#2856
Open
aulemahal wants to merge 7 commits intozarr-developers:mainfrom
Open
Open zip store from path with zip suffix#2856aulemahal wants to merge 7 commits intozarr-developers:mainfrom
aulemahal wants to merge 7 commits intozarr-developers:mainfrom
Conversation
Author
|
I did not add anything in the |
dstansby
suggested changes
Mar 4, 2025
Contributor
dstansby
left a comment
There was a problem hiding this comment.
Looks good! Just one minor comment, but I think worth fixing 👍
Author
|
Hi @dstansby , I'm not sure, but it seems your suggested change that worked in march now breaks the tests. Did some assumptions change about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipStoreif the path has a.zipsuffix.Fixes #2831
docs/user-guide/*.rstchanges/The added test is not as elegant as the other from the suite. Is there a way to get an existing zipped zarr dataset within the test suite ? Should I create another fixture instead of writing my own zarr in the test ?