Closed
Conversation
…into feature/slim-zarr
dstansby
suggested changes
Oct 18, 2024
Contributor
dstansby
left a comment
There was a problem hiding this comment.
I think we're coming to a consensus in #2391 (?) of
- Move dependency of
crc32cto numcodecs (zarr-developers/numcodecs#610) - Make
fsspecoptional
For the second one, would be good to add some docs explaining how to install the remote extra, and what functionality it enables.
jhamman
commented
Oct 18, 2024
Member
Author
|
Something I learned over the weekend is that |
jhamman
commented
Nov 13, 2024
jhamman
commented
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the main ideas from #2391, removing
crc32candfsspecas core dependencies and adding them to theshardingandremotegroups respectively. Imports are adjusted in minor ways and we now take advantage ofpytest.importorskipin a few new places.TODO: if we decide to go this route, we should have a separate part of the test matrix that includes optional dependencies.
Closes #2391
Fixes #735
TODO: