Skip to content

fix/revert 792#802

Merged
maxrjones merged 22 commits intozarr-developers:mainfrom
d-v-b:fix/revert-792
Nov 21, 2025
Merged

fix/revert 792#802
maxrjones merged 22 commits intozarr-developers:mainfrom
d-v-b:fix/revert-792

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 20, 2025

This PR partially reverts the changes in #792 by allowing either the old crc32c package or the google crc32c package to be used for the crc32c checksum. This will fix issues in zarr-python related to a missing crc32c import.

@d-v-b d-v-b mentioned this pull request Nov 20, 2025
Closed
@codecov
Copy link

codecov bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.68%. Comparing base (91dfe42) to head (1d922db).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
numcodecs/tests/test_checksum32.py 53.33% 7 Missing ⚠️
numcodecs/checksum32.py 68.42% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   89.08%   98.68%   +9.60%     
==========================================
  Files          64       64              
  Lines        2574     2595      +21     
==========================================
+ Hits         2293     2561     +268     
+ Misses        281       34     -247
Files with missing lines Coverage Δ
numcodecs/checksum32.py 94.54% <68.42%> (+2.54%) ⬆️
numcodecs/tests/test_checksum32.py 93.33% <53.33%> (+9.29%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b requested a review from jhamman November 20, 2025 22:36
@d-v-b d-v-b mentioned this pull request Nov 20, 2025
Closed
jhamman
jhamman reviewed Nov 20, 2025
View reviewed changes
jhamman
jhamman reviewed Nov 20, 2025
View reviewed changes
@maxrjones maxrjones merged commit 82fe1e5 into zarr-developers:main Nov 21, 2025
38 of 40 checks passed
@jhamman
Copy link
Member

jhamman commented Nov 21, 2025

Thanks both for sorting out this solution.

@d-v-b
Copy link
Contributor Author

d-v-b commented Nov 21, 2025

thank you @maxrjones and @jhamman!

@d-v-b d-v-b deleted the fix/revert-792 branch November 21, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjones maxrjones maxrjones left review comments

@jhamman jhamman jhamman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-v-b @jhamman @maxrjones