fetch tags to version nightly wheels correctly#790
Merged
d-v-b merged 1 commit intozarr-developers:mainfrom Sep 25, 2025
Merged
fetch tags to version nightly wheels correctly#790d-v-b merged 1 commit intozarr-developers:mainfrom
d-v-b merged 1 commit intozarr-developers:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
- Coverage 99.82% 90.33% -9.49%
==========================================
Files 64 64
Lines 2804 2804
==========================================
- Hits 2799 2533 -266
- Misses 5 271 +266 🚀 New features to boost your workflow:
|
d-v-b
approved these changes
Sep 25, 2025
Contributor
d-v-b
left a comment
There was a problem hiding this comment.
happy to ignore the test failures here, this looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a line to fetch more history in the wheels action so that the nightly wheel gets the correct version. The main release wheels worked because they were always garunteed to be on a tag instead of some random commit hash
Fixes the versions here: https://anaconda.org/scientific-python-nightly-wheels/numcodecs/files
@jhamman