Fix Zstd decompression negative size issue on 32-bit platforms (Fixes #781)#782
Merged
d-v-b merged 5 commits intozarr-developers:mainfrom Aug 19, 2025
Merged
Conversation
mkitti
commented
Aug 18, 2025
5cc5260 to
b0fe556
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 2804 2804
=========================================
Hits 2804 2804 🚀 New features to boost your workflow:
|
6ab3b78 to
786d31f
Compare
Contributor
Author
|
https://github.com/zarr-developers/numcodecs/actions/runs/17060350247/job/48365901555?pr=785 confirms that this fix addresses #781 |
avalentino
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the decompress function in numcodecs/zstd.pyx to properly handle frame content sizes that exceed size_t on 32-bit systems. It:
This prevents negative sizes from being passed to PyBytes_FromStringAndSize, resolving system errors on 32-bit platforms.
Fixes #781