Skip to content

ensure_bytes on buf for pcodec decode#756

Merged
d-v-b merged 4 commits intozarr-developers:mainfrom
slowjazz:fix-pcodecs-decode-array
Nov 20, 2025
Merged

ensure_bytes on buf for pcodec decode#756
d-v-b merged 4 commits intozarr-developers:mainfrom
slowjazz:fix-pcodecs-decode-array

Conversation

@slowjazz
Copy link
Contributor

@slowjazz slowjazz commented Jun 27, 2025

Decoding with PCodec is causing issues in upstream zarr because it's being expected to handle numpy arrays. It seems like the other codecs in this library perform input validation in their respective implementations and generally support numpy arrays as a buffer-like.

This PR:

  • calls ensure_bytes on the input type for PCodec.decode()
  • updates unit tests. the former check_encode_decode_array_to_bytes seems to be a more restrictive version of check_encode_decode_array.

ref: zarr-developers/zarr-python#3176

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@slowjazz slowjazz marked this pull request as ready for review June 27, 2025 21:48
@codecov
Copy link

codecov bot commented Nov 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.00%. Comparing base (73a21c4) to head (80d4de4).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
numcodecs/tests/test_pcodec.py 0.00% 3 Missing ⚠️
numcodecs/pcodec.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   88.83%   89.00%   +0.16%     
==========================================
  Files          64       64              
  Lines        2580     2574       -6     
==========================================
- Hits         2292     2291       -1     
+ Misses        288      283       -5
Files with missing lines Coverage Δ
numcodecs/tests/common.py 100.00% <ø> (+4.02%) ⬆️
numcodecs/pcodec.py 7.40% <50.00%> (-0.14%) ⬇️
numcodecs/tests/test_pcodec.py 12.90% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b merged commit 4613723 into zarr-developers:main Nov 20, 2025
46 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slowjazz @d-v-b