Unskip accidentally skipped tests#738
Merged
jakirkham merged 1 commit intozarr-developers:mainfrom Apr 11, 2025
dstansby:unskip-tests
Merged
Unskip accidentally skipped tests#738jakirkham merged 1 commit intozarr-developers:mainfrom dstansby:unskip-tests
jakirkham merged 1 commit intozarr-developers:mainfrom
dstansby:unskip-tests
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 63 63
Lines 2738 2738
=======================================
Hits 2737 2737
Misses 1 1
🚀 New features to boost your workflow:
|
jakirkham
approved these changes
Apr 11, 2025
Member
|
Thanks David! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
pytest.skip()is executed it skips the entire running test, not just the current for loop. This means putting apytest.skip()inside a for loop can accidentally skip tests. The fix here is to parametrize the tests instead of using for loops.