In vlen, define and use const HEADER_LENGTH#723
Merged
jakirkham merged 3 commits intozarr-developers:mainfrom Apr 7, 2025
Merged
In vlen, define and use const HEADER_LENGTH#723jakirkham merged 3 commits intozarr-developers:mainfrom
vlen, define and use const HEADER_LENGTH#723jakirkham merged 3 commits intozarr-developers:mainfrom
Conversation
Previously `HEADER_LENGTH` was defined in `vlen`, but not as `const`. So it could concievably be changed. While this didn't happen in practice, it does mean the compiler needs to generate code to check and use this value throughout. However `HEADER_LENGTH` is intended to be `const`. So define it as such. That way the compiler can generate more efficient code when using it. Further define it in terms of the type whose size it references (namely `uint32_t`). Also make sure that type is `cimport`ed for referencing. Finally consistently use `HEADER_LENGTH` when it applies throughout `vlen`. Previously `HEADER_LENGTH` was sometimes used and in other cases the value `4` was used. So consistently use `HEADER_LENGTH` throughout for improved code clarity. Now that `HEADER_LENGTH` is marked `const` this is equally efficient.
ac3cbab to
0a99c43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 63 63
Lines 2738 2738
=======================================
Hits 2737 2737
Misses 1 1 🚀 New features to boost your workflow:
|
d-v-b
approved these changes
Apr 7, 2025
Member
Author
|
Weird would have thought automerge would have waited for the rest of the checks Will keep an eye on Edit: Think this is because a small number of our checks are actually required. It may be worth revisiting this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
HEADER_LENGTHwas defined invlen, but not asconst. So it could concievably be changed. While this didn't happen in practice, it does mean the compiler needs to generate code to check and use this value throughout.However
HEADER_LENGTHis intended to beconst. So define it as such. That way the compiler can generate more efficient code when using it. Further define it in terms of the type whose size it references (namelyuint32_t). Also make sure that type iscimported for referencing.Finally consistently use
HEADER_LENGTHwhen it applies throughoutvlen. PreviouslyHEADER_LENGTHwas sometimes used and in other cases the value4was used. So consistently useHEADER_LENGTHthroughout for improved code clarity. Now thatHEADER_LENGTHis markedconstthis is equally efficient.TODO: