Minor UX improvement: Add the UnknownCodecError.#689
Merged
dstansby merged 11 commits intozarr-developers:mainfrom Jan 17, 2025
Merged
Minor UX improvement: Add the UnknownCodecError.#689dstansby merged 11 commits intozarr-developers:mainfrom
UnknownCodecError.#689dstansby merged 11 commits intozarr-developers:mainfrom
Conversation
cwognum
commented
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 62 63 +1
Lines 2749 2755 +6
=======================================
+ Hits 2741 2747 +6
Misses 8 8
🚀 New features to boost your workflow:
|
dstansby
reviewed
Jan 17, 2025
Contributor
dstansby
left a comment
There was a problem hiding this comment.
I'm very 👍 doing this, thanks for the PR. I left a suggestion for the test, and also I'm a bit on the fence about ValueError, so let me know your thoughts there.
Co-authored-by: David Stansby <dstansby@gmail.com>
Contributor
Author
d-v-b
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See zarr-developers/zarr-python#2508 for context.
Since
numcodecssupports registering custom codecs in downstream libraries, there can be situations where the environment in which data was encoded is not the same as the environment in which the data is decoded (e.g. opening a Zarr archive that was created in a different environment). This can lead to missing codecs.It would be a nice UX improvement if you catch that error and can offer codec specific solutions.
This change would enable something like:
TODO: