Skip to content

Update pyproject.toml - zfpy Versioning#671

Merged
dstansby merged 11 commits intozarr-developers:mainfrom
me-her:patch-1
Jan 4, 2025
Merged

Update pyproject.toml - zfpy Versioning#671
dstansby merged 11 commits intozarr-developers:mainfrom
me-her:patch-1

Conversation

@me-her
Copy link
Contributor

@me-her me-her commented Dec 16, 2024

Zfpy release 1.0.1 which supports numpy > 2.0.

[Description of PR]

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@me-her
Update pyproject.toml - zfpy Versioning
a40f0f0 
Zfpy release 1.0.1 which supports numpy > 2.0.
@tasansal
Copy link

tasansal commented Dec 16, 2024 •
edited
Loading

you may need to change/remove version check as well

numcodecs/numcodecs/zfpy.py

Lines 13 to 26 in 4b95d66

if _zfpy_version:
# Check NumPy version
_numpy_version: tuple = tuple(map(int, version("numpy").split('.')))
if _numpy_version >= (2, 0, 0) and _zfpy_version <= (1, 0, 1): # pragma: no cover
_zfpy_version = ()
warnings.warn(
"NumPy version >= 2.0.0 detected. The zfpy library is incompatible with this version of NumPy. "
"Please downgrade to NumPy < 2.0.0 or wait for an update from zfpy.",
UserWarning,
stacklevel=2,
)
else:
with suppress(ImportError):
import zfpy as _zfpy # type: ignore[no-redef]

@dstansby dstansby added the needs changelog Needs a changelog entry writing label Dec 17, 2024
@codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (095de5c) to head (1072b2a).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          62       62           
  Lines        2747     2747           
=======================================
  Hits         2745     2745           
  Misses          2        2
Files with missing lines Coverage Δ
numcodecs/zfpy.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@me-her
Copy link
Contributor Author

me-her commented Dec 18, 2024

@dstansby Please merge it if it's ready.

@dstansby dstansby removed the needs changelog Needs a changelog entry writing label Dec 28, 2024
dstansby
dstansby suggested changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think it's worth keeping the warning if zfpy < 1.0.0 (which needs fixing, see my inline comment), but updating the dependencies in pyproject.toml is 👍

@dstansby dstansby enabled auto-merge (squash) December 30, 2024 16:44
@dstansby dstansby disabled auto-merge January 4, 2025 15:13
@dstansby dstansby merged commit 7cdffa1 into zarr-developers:main Jan 4, 2025
@dstansby dstansby added the needs changelog Needs a changelog entry writing label Jan 4, 2025
@dstansby dstansby mentioned this pull request Jan 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dstansby dstansby dstansby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs changelog Needs a changelog entry writing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@me-her @tasansal @dstansby