Skip checksum32 tests if crc32c is missing#635
Merged
jakirkham merged 1 commit intozarr-developers:mainfrom Nov 13, 2024
Merged
Skip checksum32 tests if crc32c is missing#635jakirkham merged 1 commit intozarr-developers:mainfrom
checksum32 tests if crc32c is missing#635jakirkham merged 1 commit intozarr-developers:mainfrom
Conversation
3 tasks
checksum32 tests if crc32 is missingchecksum32 tests if crc32c is missing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 99.81% 94.54% -5.28%
==========================================
Files 62 62
Lines 2711 2712 +1
==========================================
- Hits 2706 2564 -142
- Misses 5 148 +143
|
dstansby
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
crc32cis not installed, skip the tests intest_checksum32.py.TODO: