Error on warnings when testing#620
Merged
dstansby merged 6 commits intozarr-developers:mainfrom Nov 7, 2024
dstansby:filterwarnings
Merged
Error on warnings when testing#620dstansby merged 6 commits intozarr-developers:mainfrom dstansby:filterwarnings
dstansby merged 6 commits intozarr-developers:mainfrom
dstansby:filterwarnings
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2405 2407 +2
=======================================
+ Hits 2403 2405 +2
Misses 2 2
|
dstansby
commented
Nov 5, 2024
| shell: "bash -l {0}" | ||
| run: | | ||
| conda activate env | ||
| python -m pip install "zfpy>=1" "numpy<2" |
Contributor
Author
There was a problem hiding this comment.
This is needed to avoid zfpy trying to install a very old version of numpy. Instead, by installing the extra, it respects the minimum version of numpy supported by numcodecs.
Contributor
Author
|
pre-commit.ci autofix |
normanrz
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before #619, it would be good to convert test warnings to errors, so we can make sure there aren't any warnings being raised that we're not expecting.