Delay initialization of multiprocessing.Lock until it's needed#615
Merged
dstansby merged 2 commits intozarr-developers:mainfrom Oct 28, 2024
Merged
Conversation
9b5de74 to
d7a4363
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2405 2405
=======================================
Hits 2403 2403
Misses 2 2 |
Member
|
Thank you for fixing this long standing bug! 🙏 Would be curious to hear how you arrived at this solution? |
Contributor
Author
|
I picked up a suggestion from astropy/astropy#16351 (comment), so credit goes to @saimn for figuring it out. I'm just the muscle here 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Description of PR]
Fixes #522
I'm not sure how to properly test this though, as the test would need to run before numcodecs is even imported the first time, which seems hard to control with how pytest collects all tests before running any particular one.
TODO: