Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2326 2405 +79
=======================================
+ Hits 2324 2403 +79
Misses 2 2
|
|
Should this live in https://github.com/zarr-developers/numcodecs/blob/main/numcodecs/checksum32.py, where we already have |
|
I didn't look for |
|
I moved the code to checksum32.py and refactored the tests (they had no parameterization) in 7e78d93 |
dstansby
left a comment
There was a problem hiding this comment.
Looks good to me - just a few questions, but none of them blocking.
|
I don't see why this PR isn't ready to merge (it might be just late)? Do I need another approval? |
dstansby
left a comment
There was a problem hiding this comment.
Maybe just needs a fresh approval?
Adds Crc32c codec, which appends a crc32c checksum to the input buffer when encoding and validates the checksum when decoding.
Fixes #610
TODO: