Merged
Conversation
jakirkham
reviewed
Oct 16, 2024
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Sam! 🙏
This is a good point to follow up
Would actually recommend just copying to start and then doing everything in-place on the copy. Otherwise we are generating a lot of temporary arrays
Mention this as we are doing compression memory usage can be an issue. So we want to reduce the amount of temporary arrays we create if possible
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
jakirkham
approved these changes
Oct 17, 2024
Member
|
Thanks Sam! 🙏 |
rabernat
approved these changes
Oct 17, 2024
7 tasks
Member
|
Release note is in PR: #609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was benchmarking different compression options and realized
BitRoundwas overwriting my array in place.Looks like there was discussion on this in the original PR but nothing came of it. Making an explicit copy seems to work fine as well, not sure which is preferred?
cc @rabernat
TODO: