Enforce ruff/flake8-comprehensions rules (C4)#605
Merged
dstansby merged 4 commits intozarr-developers:mainfrom Nov 29, 2024
Merged
Enforce ruff/flake8-comprehensions rules (C4)#605dstansby merged 4 commits intozarr-developers:mainfrom
dstansby merged 4 commits intozarr-developers:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 62 62
Lines 2721 2721
=======================================
Hits 2719 2719
Misses 2 2
|
28fc72c to
aad144b
Compare
69f9354 to
3668e6c
Compare
3668e6c to
7214791
Compare
5218185 to
bcb3ab2
Compare
C401 Unnecessary generator (rewrite as a `set` comprehension)
C408 Unnecessary `dict` call (rewrite as a literal)
bcb3ab2 to
2e60dcd
Compare
dstansby
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: