Increase speed of Delta encoding using np.subtract#584
Increase speed of Delta encoding using np.subtract#584dstansby merged 4 commits intozarr-developers:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2332 2332
=======================================
Hits 2330 2330
Misses 2 2
|
|
Looks good to me 👍 - could you just leave a comment above the line you changed explaining that you're using |
|
Sure! I will leave a comment. |
|
Thanks Lee and David! 🙏 This is a good improvement. Always good to avoid unneeded array creation and copies 🙂 Noticed that |
|
Breaks zarr: #653 |
This PR accelerated Delta encoding by replacing
np.diffintonp.subtract.Using inplace operation of
np.subtractreduce array creation time.Here is a simple benchmark:
TODO: