Skip to content

Remove Sphinx pinning#552

Merged
dstansby merged 1 commit intozarr-developers:mainfrom
QuLogic:unpin-sphinx
Aug 11, 2024
Merged

Remove Sphinx pinning#552
dstansby merged 1 commit intozarr-developers:mainfrom
QuLogic:unpin-sphinx

Conversation

@QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jul 21, 2024

This was pinned in #434 because of the RTD theme, but #485 switched to the pydata sphinx theme, so there should not be any issues.

Fixes #435

TODO:

  • Unit tests and/or doctests in docstrings
  • [n/a] Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (9617e6f) to head (94c2bf1).
Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2339     2339           
=======================================
  Hits         2337     2337           
  Misses          2        2           

This was pinned in zarr-developers#434 because of the RTD theme, but zarr-developers#485 switched to
the pydata sphinx theme, so there should not be any issues.

Fixes zarr-developers#435
@dstansby dstansby merged commit 8b53fc1 into zarr-developers:main Aug 11, 2024
@QuLogic QuLogic deleted the unpin-sphinx branch August 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review RTD pin

2 participants