You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, PR workflows run tests and build wheels.
Meanwhile, the wheel workflow runs full tests again.
This PR changes the wheel tests to just check that numcodecs is import-able, to reduce CI time.
See #427 (comment) and followup thread.
Note: could add something more to the command beyond importing, but I'm not sure what would be useful.
TODO:
Unit tests and/or doctests in docstrings
Tests pass locally
Docstrings and API docs for any new/modified user-facing classes and functions
The original build with arm64 macOS PR:
This PR:
Older, unrelated docs PR (no changes to wheels, no arm64 macOS)
Not sure the runners are reliably the same, but the testing time savings is greatest on macOS.
Python 3.8 is particularly slow BTW (and no longer supported by numpy...)
Considering msgpack, etc. were not installed by the wheels build anyway, the call to pytest couldn't currently have been comprehensive. I imagine there's more unification that could happen between the builds, but for the moment, this seems like a straight-forward enough simplification. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, PR workflows run tests and build wheels.
Meanwhile, the wheel workflow runs full tests again.
This PR changes the wheel tests to just check that numcodecs is import-able, to reduce CI time.
See #427 (comment) and followup thread.
Note: could add something more to the command beyond importing, but I'm not sure what would be useful.
TODO: