Merged
Conversation
jni
approved these changes
Feb 7, 2022
|
Slight note, possibly not important, but I think it would make more sense re sparse writing to say it was added by Davis and me, rather than me and Davis. He did the hard work on the implementation, I changed a flag from True to False 😂. |
Member
|
Sure @jni. 👍🏻 |
joshmoore
commented
Feb 8, 2022
Member
Author
joshmoore
left a comment
There was a problem hiding this comment.
Few points (I pushed commits for them)
Member
|
All changes are done. Merging this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @MSanKeys963
fix: zarr-developers/zarr-python#901