Skip to content

Improve ManifestStore.list_dir for arrays and nested groups#837

Merged
maxrjones merged 8 commits intozarr-developers:mainfrom
maxrjones:improve-list-dir
Nov 14, 2025
Merged

Improve ManifestStore.list_dir for arrays and nested groups#837
maxrjones merged 8 commits intozarr-developers:mainfrom
maxrjones:improve-list-dir

Conversation

@maxrjones
Copy link
Member

@maxrjones maxrjones commented Nov 13, 2025 •
edited
Loading

The listing functionality in ManifestStore previously assumed a maximum hierarchy depth of 2. Following the addition of nested group support, we need to expand the functionality.

I would greatly appreciate feedback if there's a way to make this logic less gnarly.

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.40%. Comparing base (c6de7b3) to head (baaab1d).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
virtualizarr/manifests/store.py 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   88.32%   88.40%   +0.07%     
==========================================
  Files          35       35              
  Lines        1988     2000      +12     
==========================================
+ Hits         1756     1768      +12     
  Misses        232      232
Files with missing lines Coverage Δ
virtualizarr/manifests/store.py 88.72% <95.83%> (+0.29%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones requested a review from chuckwondo November 13, 2025 20:35
chuckwondo
chuckwondo requested changes Nov 13, 2025
View reviewed changes
@maxrjones @chuckwondo
Update virtualizarr/manifests/store.py
d1595b4 
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@maxrjones @chuckwondo
Apply suggestions from code review
9c0e803 
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@maxrjones
Copy link
Member Author

maxrjones commented Nov 13, 2025

Thank you @chuckwondo, your suggestions made the code much cleaner!

chuckwondo
chuckwondo approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxrjones maxrjones added the bug Something isn't working label Nov 14, 2025
@maxrjones maxrjones mentioned this pull request Nov 14, 2025
Merged
9 tasks
@maxrjones maxrjones merged commit 38ef649 into zarr-developers:main Nov 14, 2025
15 checks passed
@maxrjones maxrjones mentioned this pull request Jan 12, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chuckwondo chuckwondo chuckwondo approved these changes

@TomNicholas TomNicholas TomNicholas approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxrjones @chuckwondo @TomNicholas