Allow storing scalar arrays under 'c' key#836
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 88.43% 88.32% -0.11%
==========================================
Files 35 35
Lines 1988 1988
==========================================
- Hits 1758 1756 -2
- Misses 230 232 +2
🚀 New features to boost your workflow:
|
chuckwondo
requested changes
Nov 13, 2025
Co-authored-by: Chuck Daniels <chuck@developmentseed.org>
for more information, see https://pre-commit.ci
Co-authored-by: Chuck Daniels <chuck@developmentseed.org>
TomNicholas
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR strengthens the key parsing in
ChunkManifest, reusing/generalizing logic about the Zarr hierarchy fromManifestStore.@neilSchroeder, I hope this will address the issues you were finding, which I think was a bug in the ChunkManifest logic rather than the Zarr parser. Sorry for the redundancy with your PR in #835, I just didn't think you should need to workaround this.
Fixes #834