Add supports_consolidated_metadata to ManifestStore#809
Merged
jsignell merged 3 commits intozarr-developers:mainfrom Nov 28, 2025
Merged
Add supports_consolidated_metadata to ManifestStore#809jsignell merged 3 commits intozarr-developers:mainfrom
jsignell merged 3 commits intozarr-developers:mainfrom
Conversation
Member
Contributor
Author
|
Thanks for reminding me about this one @maxrjones! I think I just wanted to add a test. |
d1f793b to
2e40a48
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 88.50% 88.41% -0.09%
==========================================
Files 35 35
Lines 2000 2003 +3
==========================================
+ Hits 1770 1771 +1
- Misses 230 232 +2
🚀 New features to boost your workflow:
|
maxrjones
approved these changes
Nov 26, 2025
Member
maxrjones
left a comment
There was a problem hiding this comment.
Thanks, looks good! The failures seem to be due to an unrelated change in the Minio API.
0d98848 to
6875a03
Compare
Contributor
Author
|
This branch had some weirdness because my upstream location was still set to https://github.com/TomNicholas/VirtualiZarr rather than this repo. Looks better now although there is still a docs test failure. |
TomNicholas
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was just experimenting with using
ManifestStores directly and got tired of typingconsolidated=False.docs/releases.rstapi.rst