Skip to content

Add supports_consolidated_metadata to ManifestStore#809

Merged
jsignell merged 3 commits intozarr-developers:mainfrom
jsignell:consolidated-metadata
Nov 28, 2025
Merged

Add supports_consolidated_metadata to ManifestStore#809
jsignell merged 3 commits intozarr-developers:mainfrom
jsignell:consolidated-metadata

Conversation

@jsignell
Copy link
Contributor

@jsignell jsignell commented Sep 30, 2025

I was just experimenting with using ManifestStores directly and got tired of typing consolidated=False.

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@maxrjones
Copy link
Member

FYI @jsignell, #827 also removes the need to explicitly set consolidated=False. I'd still definitely support using this approach if you're interested in continuing with the PR. Just ping if/when you'd like a review.

@jsignell
Copy link
Contributor Author

Thanks for reminding me about this one @maxrjones! I think I just wanted to add a test.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.41%. Comparing base (0a18a00) to head (6875a03).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   88.50%   88.41%   -0.09%     
==========================================
  Files          35       35              
  Lines        2000     2003       +3     
==========================================
+ Hits         1770     1771       +1     
- Misses        230      232       +2     
Files with missing lines Coverage Δ
virtualizarr/manifests/store.py 88.97% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsignell jsignell requested a review from maxrjones November 26, 2025 19:15
@jsignell jsignell marked this pull request as ready for review November 26, 2025 19:15
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! The failures seem to be due to an unrelated change in the Minio API.

@jsignell
Copy link
Contributor Author

This branch had some weirdness because my upstream location was still set to https://github.com/TomNicholas/VirtualiZarr rather than this repo. Looks better now although there is still a docs test failure.

@jsignell jsignell merged commit cf8e0db into zarr-developers:main Nov 28, 2025
14 of 15 checks passed
@jsignell jsignell deleted the consolidated-metadata branch November 28, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants