Do not validate references for "empty" chunks.#791
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 87.74% 87.75%
=======================================
Files 35 35
Lines 1885 1886 +1
=======================================
+ Hits 1654 1655 +1
Misses 231 231
🚀 New features to boost your workflow:
|
TomNicholas
approved these changes
Aug 29, 2025
Member
TomNicholas
left a comment
There was a problem hiding this comment.
🙏
Changelog entry please!
Collaborator
Author
|
@TomNicholas Changelog updated 👍. |
maxrjones
reviewed
Sep 3, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, serializing a
ManifestArraycontaining empty chunks to Icechunk requires explicitly passingvalidate_containers=Falsetoto_icechunkwhich may be counterintuitive for some users. ref #740. This PR changes the current behavior to only perform reference validation for references with apath.