Extract endianness from Bytes codec in V2 metadata conversion#769
Merged
TomNicholas merged 5 commits intozarr-developers:mainfrom Aug 14, 2025
Merged
Extract endianness from Bytes codec in V2 metadata conversion#769TomNicholas merged 5 commits intozarr-developers:mainfrom
TomNicholas merged 5 commits intozarr-developers:mainfrom
Conversation
Collaborator
|
Yep, this works for my use case! |
TomNicholas
approved these changes
Aug 12, 2025
Member
TomNicholas
left a comment
There was a problem hiding this comment.
Thank you! Let's just make sure this important bugfix is in the changelog.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 87.71% 87.75% +0.03%
==========================================
Files 35 35
Lines 1872 1878 +6
==========================================
+ Hits 1642 1648 +6
Misses 230 230
🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements #766 by adding to_kerchunk support (whereas #766 added to_icechunk support). For a more robust long-term solution that would eliminate the need for separate metadata pipelines between kerchunk and icechunk, see issue #768.
@rsignell I tested your workflow works using this PR (see https://github.com/maxrjones/test-scripts/blob/main/test-virtualizarr-netcdf3/test-virtualizarr.py).
docs/releases.rstapi.rst