Minor improvements to dmrpp parser#757
Minor improvements to dmrpp parser#757TomNicholas merged 7 commits intozarr-developers:mainfrom Mikejmnez:dmrpp_parser
Conversation
|
Excellent! Would be great to get these fixes in - let me know once you need a review. |
|
@TomNicholas Apologies that it took me too long to come back to this, but things have been extremely busy... I added a minor test for the minor improvements I am adding. These are:
@betolink Lastly, there are some other issues with some variables, mostly metadata variables, and these can be dropped during the parsing. So for now, I think this may at least enable data exploration of IceSat2 data and I can look what is going on with those metadata variables on a separate issue |
|
Please add a note to the release notes! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 87.75% 87.74% -0.02%
==========================================
Files 35 35
Lines 1879 1885 +6
==========================================
+ Hits 1649 1654 +5
- Misses 230 231 +1
🚀 New features to boost your workflow:
|
|
Ready to merge? |
|
Yes, ready to merge :). Thanks @TomNicholas ! |
Hi my first PR! I took a quick look at some dmrpp issues and decided to provide some fixes.
test-py311)docs/releases.rstapi.rstNew in this draft PR:
Container attributes, if present the parser warns and drops the attribute (for now) rather than raise a
ValueError, thus enabling the generation of the virtual dataset. With this, I am able to read IceSAT-2 data (albeit I need to drop some variables) (Support flattened dmrpp files. #581). Container attributes are an outdated approach (dating several years back), should not exist (beyond thebuild_dmrppspecific container attribute, which the current parser drops), and are a consequence of flatenning dmrpps. There is an ongoing withinnsidcto update dmrpps. But in the meantime I figure we can (potentially) unflatten these container attrs. I will implement that.Improves the handling of scalar variables (arrays with no
dim). With this, I am able to read the daymet file described in (dmrpp parsing fails for variables without a dim #666)