Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the implementation of
__getitem__to actually satisfy the myriad edge cases in the array API standard. I didn't realise just how gnarly this could get until I was debugging #728.The test coverage is now way better, and the algorithm by which we do indexing much more explicit.
In this refactor it becomes obvious that 95% of the logic is for dealing with
NoneandEllipsis- the actual 1D indexing is extremely simple (partly because we only support specific no-ops right now).This refactor should also make it much easier to add support for #51.
docs/releases.rstNew functions/methods are listed inapi.rstNew functionality has documentation