fix(cache): sbom cachepath existence#4762
Merged
brandtkeller merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The {cache}/images directory is only created as a side effect of images.Pull(). When a package uses imageArchives instead of pulling from a registry, componentImages is empty, Pull() is never called, and nobody creates that directory. But
createImageSBOMruns unconditionally (unless SBOM is skipped) and passes filepath.Join(cachePath, ImagesDir) to stereoscope, which assumes it exists and fails when it tries to write uncompressed layer data into it via os.Create.This PR was specifically scoped to the identified issue. I think there is room for evaluating common entrypoints for library defaults.
Related Issue
Fixes #4735
Relates to #
Checklist before merging