Skip to content

feat: split wait-for command#4614

Merged
AustinAbro321 merged 17 commits intomainfrom
wait-for-resource-default-ready
Feb 20, 2026
Merged

feat: split wait-for command#4614
AustinAbro321 merged 17 commits intomainfrom
wait-for-resource-default-ready

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

@AustinAbro321 AustinAbro321 commented Feb 19, 2026

Description

This deprecates the wait-for command in favor of sub commands zarf tools wait-for resource and zarf tools wait-for network

Related Issue

Fixes #4550
Fixes: #4077

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2026

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit e598083
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6998804e6aa18e0008f01e7b
😎 Deploy Preview https://deploy-preview-4614--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 19.49686% with 128 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/wait/wait.go 0.00% 98 Missing ⚠️
src/cmd/wait.go 50.81% 30 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/wait.go 47.47% <50.81%> (+5.36%) ⬆️
src/pkg/wait/wait.go 11.87% <0.00%> (-4.05%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review February 20, 2026 13:17
@AustinAbro321 AustinAbro321 requested review from a team as code owners February 20, 2026 13:17
brandtkeller
brandtkeller previously approved these changes Feb 20, 2026
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits but otherwise lgtm - Worked through a number of tests locally and could not find a gap.

Comment thread site/src/content/docs/commands/zarf_tools_wait-for_resource.md Outdated
Comment thread src/pkg/wait/wait.go Outdated
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit 3340ead Feb 20, 2026
42 checks passed
@AustinAbro321 AustinAbro321 deleted the wait-for-resource-default-ready branch February 20, 2026 17:39
@github-project-automation github-project-automation Bot moved this to Done in Zarf Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

2 participants