Adding Gitea Virtual Service to Big Bang example#1475
Merged
Racer159 merged 2 commits intozarf-dev:mainfrom Mar 27, 2023
Merged
Adding Gitea Virtual Service to Big Bang example#1475Racer159 merged 2 commits intozarf-dev:mainfrom
Racer159 merged 2 commits intozarf-dev:mainfrom
Conversation
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Racer159
suggested changes
Mar 26, 2023
Contributor
Racer159
left a comment
There was a problem hiding this comment.
Just a few changes to make it more configurable
Contributor
|
Thanks for the PR! Requested a few changes and this will also need your base branch to be updated prior to merge. |
07d4241 to
2a800ad
Compare
Contributor
Author
|
Updated and tested with requested changes. |
Racer159
previously approved these changes
Mar 27, 2023
Contributor
Racer159
left a comment
There was a problem hiding this comment.
lgtm, but you will need to update the base branch again
a355a36 to
b4a7242
Compare
Contributor
Author
thanks for the heads up, done. |
b4a7242 to
247e40c
Compare
YrrepNoj
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I thought I would expand the example by showing a relevant and useful addition. Since Gitlab is typically deployed with Big Bang, this would give somewhat of an equivalent feel to be able to not have to worry about setting up a proxy forward for the service for Gitea.
Related Issue
N/A
Type of change
Checklist before merging