fix(create): built package path separators#4857
Merged
brandtkeller merged 6 commits intomainfrom Apr 28, 2026
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
| for di, d := range comp.DataInjections { | ||
| check(prefix+".dataInjections["+strconv.Itoa(di)+"].source", d.Source) | ||
| } | ||
| actionsByName := map[string][]v1alpha1.ZarfComponentAction{ |
Member
There was a problem hiding this comment.
I wasn't sure if this would cause a bug since windows users still use these paths, but it looks like windows is okay with a forward slash as a separator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I bumped this issue in priority after realizing the implications.
Built Zarf packages should be byte-identical across operating systems, but filepath.Join was producing OS-native separators in path strings that get serialized into the published zarf package.
This really only impacts import/skeletons and how paths are resolved to my knowledge. Worth doing now as a pattern before we introduce any new import/component behaviors.
This statically defines checksums in testing which can be a burden during development when the package shape changes but a worthwhile tradeoff for reproducibility.
Related Issue
Fixes #3275
Relates to #
Checklist before merging