Skip to content

fix: ensure zarf say honors no-color#4850

Merged
AustinAbro321 merged 2 commits intozarf-dev:mainfrom
mjnagel:fix-say-no-color
Apr 28, 2026
Merged

fix: ensure zarf say honors no-color#4850
AustinAbro321 merged 2 commits intozarf-dev:mainfrom
mjnagel:fix-say-no-color

Conversation

@mjnagel
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel commented Apr 24, 2026

Description

Ensures that zarf say honors the --no-color flag.

Related Issue

N/A

Checklist before merging

@mjnagel mjnagel requested review from a team as code owners April 24, 2026 18:29
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 725add1
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69f0e322224809000891b5fd

Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/say.go 0.00% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/say.go 7.69% <0.00%> (-0.65%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the scope and impact I don't have an issue accepting this.

Given that message import - which checks whether color is enabled or disabled through pterm - I discovered pterm has a RemoveColorFromString() function. Using it or wrapping in a message function would also be acceptable.

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Apr 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 27, 2026
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Apr 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 27, 2026
@AustinAbro321 AustinAbro321 enabled auto-merge April 28, 2026 16:41
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into zarf-dev:main with commit f9748d5 Apr 28, 2026
32 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Zarf Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants