fix: ensure zarf say honors no-color#4850
Merged
AustinAbro321 merged 2 commits intozarf-dev:mainfrom Apr 28, 2026
Merged
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
c833889 to
3c667fe
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
brandtkeller
approved these changes
Apr 24, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
Given the scope and impact I don't have an issue accepting this.
Given that message import - which checks whether color is enabled or disabled through pterm - I discovered pterm has a RemoveColorFromString() function. Using it or wrapping in a message function would also be acceptable.
AustinAbro321
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures that
zarf sayhonors the--no-colorflag.Related Issue
N/A
Checklist before merging