fix(template): add to dissallowed functions#4848
Merged
brandtkeller merged 3 commits intomainfrom Apr 24, 2026
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
AustinAbro321
previously approved these changes
Apr 24, 2026
Member
|
Not sure why test-site is only failing now, but we were using http:// instead of https:// which was causing it to not get filtered by our regex. We should be fine to change it to https:// |
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
AustinAbro321
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the sprig function
getHostByNameas it creates additional avenues for unintentional network calls for which Zarf would want to protect against on all operations.Related Issue
No related issue
Checklist before merging