feat: parse multi doc zarf.yaml files#4827
Merged
AustinAbro321 merged 12 commits intomainfrom Apr 17, 2026
Merged
Conversation
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
brandtkeller
requested changes
Apr 16, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
minor nits otherwise tracing the logic currently in the debugger
| {version: v1alpha1.APIVersion, priority: 1, decode: decodeV1Alpha1}, | ||
| } | ||
|
|
||
| // Parse parses a package definition |
Member
There was a problem hiding this comment.
nit: if someone is looking at the doccomments for Parse and ParseMultiDoc - do we have enough information here to help them understand the distinction of when to use each?
Member
Author
There was a problem hiding this comment.
Added to the parse comment
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com> Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
brandtkeller
approved these changes
Apr 17, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
lgtm - either purposefully or otherwise the errors for parsing yaml that isn't a zarf manifest begin to become more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements parsing for multi doc Zarf packages, which will be used in built packages according to zarf-dev/proposals#48. This also implements parsing for arbitrary API versions. Right now there is only v1alpha1, but when a new API version is added, it can be easily converted to the return type
Relates to #3433
Checklist before merging