Skip to content

fix: git host matching#4801

Merged
AustinAbro321 merged 2 commits intomainfrom
fix-credential-matching
Apr 8, 2026
Merged

fix: git host matching#4801
AustinAbro321 merged 2 commits intomainfrom
fix-credential-matching

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

Description

This makes Git host matching more accurate

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 8, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 715714f
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69d6786fe34f57000895f394

@AustinAbro321 AustinAbro321 changed the title fix: Git host matching fix: git host matching Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/utils/auth.go 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/utils/auth.go 78.19% <85.71%> (+5.53%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321 AustinAbro321 marked this pull request as ready for review April 8, 2026 15:20
@AustinAbro321 AustinAbro321 requested review from a team as code owners April 8, 2026 15:20
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One observation otherwise ready to approve.

Comment thread src/pkg/utils/auth_test.go
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 20bead2 Apr 8, 2026
32 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-credential-matching branch April 8, 2026 16:46
@github-project-automation github-project-automation Bot moved this to Done in Zarf Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants