Skip to content

fix: use cli tmpdir arg for image unpacks#4618

Merged
brandtkeller merged 1 commit intozarf-dev:mainfrom
goubew:4617_tmpdir_for_unpack
Feb 19, 2026
Merged

fix: use cli tmpdir arg for image unpacks#4618
brandtkeller merged 1 commit intozarf-dev:mainfrom
goubew:4617_tmpdir_for_unpack

Conversation

@goubew
Copy link
Copy Markdown
Contributor

@goubew goubew commented Feb 19, 2026

Description

Adds the TempDirectory config value to the unpack TempDirectory. I was able to compile and test that the changes moved the TempDirectory.

Related Issue

Fixes #4617

Checklist before merging

New to Zarf (and to golang really). This change seems small enough to me to not require new tests, but please let me know if that is not the case.

@goubew goubew requested review from a team as code owners February 19, 2026 20:04
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 19, 2026 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 531fc9f
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69976ed6905b0b000ad4d590

@goubew goubew mentioned this pull request Feb 19, 2026
Closed
@goubew
fix: use cli tmpdir arg for image unpacks
531fc9f 
Signed-off-by: goubew <goubew@users.noreply.github.com>
@goubew goubew force-pushed the 4617_tmpdir_for_unpack branch from 9de15c6 to 531fc9f Compare February 19, 2026 20:13
@goubew
Copy link
Copy Markdown
Contributor Author

goubew commented Feb 19, 2026 •
edited
Loading

I pushed an amend that changes the title fix: Use cli tmpdir arg for image unpacks to fix: use cli tmpdir arg for image unpacks to appease the commitlint.

@brandtkeller brandtkeller changed the title fix: Use cli tmpdir arg for image unpacks fix: use cli tmpdir arg for image unpacks Feb 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/pkg/images/unpack.go 54.09% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandtkeller brandtkeller added this pull request to the merge queue Feb 19, 2026
Merged via the queue into zarf-dev:main with commit ea6dc0f Feb 19, 2026
31 of 32 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Zarf Feb 19, 2026
@zarf-release-please zarf-release-please Bot mentioned this pull request Feb 19, 2026
Merged
@goubew goubew deleted the 4617_tmpdir_for_unpack branch February 19, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a1994sc a1994sc a1994sc approved these changes

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Zarf
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Image unpacks do not respect --tmpdir flag

4 participants

@goubew @a1994sc @AustinAbro321 @brandtkeller