fix(wait): ensure cluster is connectable in loop#4616
Merged
brandtkeller merged 3 commits intomainfrom Feb 19, 2026
Merged
Conversation
Signed-off-by: Austin Abro <austinabro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
brandtkeller
requested changes
Feb 19, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
one super minor go-back otherwise lgtm
Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com> Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
brandtkeller
approved these changes
Feb 19, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
I appreciate the distinct cluster connectivity check. lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #4567 we added a cluster to check to mimic the kubectl get on a loop behavior that would wait if the cluster was not available, however since the loop continues when a rest config is found, and not when a cluster connection is successful, it's possible to continue on a bad rest config then be in an unrecoverable state.
Checklist before merging