fix(make): always run unit tests with -race flag#4610
Merged
AustinAbro321 merged 2 commits intozarf-dev:mainfrom Feb 18, 2026
Merged
fix(make): always run unit tests with -race flag#4610AustinAbro321 merged 2 commits intozarf-dev:mainfrom
AustinAbro321 merged 2 commits intozarf-dev:mainfrom
Conversation
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
Author
|
The 2nd commit (not mine) lgtm |
brandtkeller
approved these changes
Feb 18, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
changes lgtm.
Speaking out-loud to document my understanding AND the changes performed to resolve the race condition (for future reference):
- Move from a package level global http client to independent http clients per invocation removed the race to write
.Transport - The use of an outer-scoped
errfrom goroutines is now shadowed with a goroutine-local:=.
We still have a few other violations of goroutine-local patterns but they are not race conditions so not pertinent to block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever running unit tests we should be using
-raceflag, to detect any race problems early on.Related Issue
None
Checklist before merging