fix: template variables and values in .wait actions#4604
Merged
AustinAbro321 merged 11 commits intomainfrom Feb 17, 2026
Merged
fix: template variables and values in .wait actions#4604AustinAbro321 merged 11 commits intomainfrom
.wait actions#4604AustinAbro321 merged 11 commits intomainfrom
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
.wait actions.wait actions
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
brandtkeller
requested changes
Feb 13, 2026
Member
brandtkeller
left a comment
There was a problem hiding this comment.
Super minor nit - otherwise I am just running some additional tests.
Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com> Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
… into fix-wait-variable-template
Member
Author
|
Fixed some new lint errors in this PR also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4603 which is a regression from #4549. In #4549, we no longer sent the command as a bash command, meaning environment variables of variables were not applied. Values templating was also no longer applied.
Checklist before merging