fix(tauri): ensure sidecar process is killed when app window is closed#945
Merged
Conversation
Previously, the app only sent an HTTP shutdown request to the Python sidecar with no timeout and no fallback. If the request failed, the sidecar process became orphaned, causing memory leaks. - Add 3-second timeout to the HTTP shutdown request - Add fallback to force-kill the sidecar by PID (taskkill /F /T on Windows, kill -9 on Unix) after HTTP shutdown attempt - Store child PID in AppState for use in both window close handler and Tauri command shutdown Fixes #944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the app only sent an HTTP shutdown request to the Python sidecar with no timeout and no fallback. If the request failed, the sidecar process became orphaned, causing memory leaks.
Fixes #944