Possible bug fix for "Open with default app" on Windows#943
Merged
Conversation
Owner
|
LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with the IIB extension in Forge WebUI locally on my Windows PC, I noticed a problem when using "Open with default app". Initially it works as expected: The Windows default Photo Viewer opens and lets me work with the image. However when I open another image, it is no longer possible to edit the image and trying to do so will result in error messages. Fortunately, the error does not persist and opening the file manually works fine.
I found that replacing the subprocess call with os.startfile gets rid of this behavior and everything seems to works as expected. I did not test whether the problem occurs with other default image viewers as well, but I still wanted to propose this solution.