Fix ComfyUI prompt extraction for ImpactWildcardProcessor#933
Conversation
|
Please provide a few sample image files so I can test. |
|
This image is not one that was expected to be compatible because it contains an SD3 workflow. However, it appears that both the original tool.py and the modified tool.py are obtaining equivalent results in my environment. |
|
I had also noticed that negative prompt, which seems odd to me as well. However, since the main focus this time was on adapting to ImpactWildcardProcessor, and since the issue also occurs in the original |
|
Speaking of parsers, I wonder if the difference in whether prompts are highlighted with squares is determined by detecting and sorting the difference between tags and natural language? There are some images where spaces unintentionally became tab indents, and I feel like it breaks down in those cases. |
|
Thank you for the detailed explanation about your approach. However, I'd like to address some concerns and propose an alternative implementation strategy. Issue with Current ApproachLooking at the screenshots I provided earlier, notice that the negative prompt issue you mentioned (where negative prompt contains the model name) does not occur in the master branch based on my testing. This appears to be a new issue introduced by the changes. Concerns About the Implementation
Proposed Alternative ApproachI believe a more conservative approach would be better: 1. Keep the current implementation intact in
|
|
First of all, I deeply appreciate your kind and thorough explanation and guidance. Thanks to that, I believe the corrections have been completed successfully without any issues. To be honest and swallowing my embarrassment, since I'm only a hobby-level programmer, this might be beyond my skill level. Anyway, it seems to be working properly now, so please check it out. :D |
|
Thanks for your contribution. |






Summary
Fix ComfyUI prompt extraction for workflows using
ImpactWildcardProcessor.What changed
populated_textoverwildcard_textFluxGuidanceWhy
wildcard_textcontains the template before wildcard expansion, whilepopulated_textcontains the final prompt actually used for generation.This change ensures the extracted prompt matches the real generated prompt.