include hyphen in LoRA tag model name matching & improve performance#898
Merged
Conversation
- Add tag name validation in Tag.get_or_create method - Chinese names: max 16 characters - Other languages: max 8 words - Return error tags with uppercase English names when validation fails - Ensure error tags are created through get_or_create to maintain database consistency - Clean up database: removed 487,938 non-custom tags, keeping only 12 custom tags
Important performance optimization for handling large tag datasets: - When total tags > 8192, limit 'pos' type tags to top 4096 by count - Return all non-pos tags without limitation - Significantly reduces memory usage and load time for large databases - Maintains functionality while improving performance with massive tag counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.