added compatibility with several comfyUI workflows#772
Merged
Conversation
Contributor
Author
|
New improvement in the loop for searching for KSampler node, because some of my sources has a key over 32. I thing is better to do the for loop over the data.keys(), and it's more efficient because only test existing nodes. |
zanllp
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First improvement:
The input to a KSampler model is not always from a LoadCheckPoint node, as it can be mediated by a LoadLora or similar. In these cases, IIB was failing and not continuing the execution of the function.
Note that in python "get" doesn't cause error if the key doesn't exists. Instead of this, it returns None. This not get properly the model used, but at least get the rest of the params.
Second improvement:
The code assumes the "positive" input of KSampler is the positive prompt, but may not be the case. Some flux.1 workflows have a node "Guidance" between the positive prompt and the KSampler.
If there is a FluxGuidance node then give an step back to get the prompt.
Images to test: